fix: tailor dependency-age report per gradle update PR.#11602
Conversation
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
| @@ -429,24 +429,51 @@ def validate_lockfiles(args: argparse.Namespace) -> int: | |||
|
|
|||
| reverted_files = len(violations_by_file) | |||
| summary = build_validation_summary(violations_by_file=violations_by_file, replacements_by_file=replacements_by_file, baseline_lockfiles=baseline_lockfiles, min_age_hours=args.min_age_hours) | |||
There was a problem hiding this comment.
It seems like we no longer need the summary variable now, so we can clean that up 🤔 (here and in emit_outputs)
There was a problem hiding this comment.
Nice catch! I applied this suggestion and also added tests.
Please take a look one more time :)
|
/merge -f --reason "Not a code change, just refined report for GtiHub 48h action, no need to pass MQ" |
|
View all feedbacks in Devflow UI.
The expected merge time in
Warning This change was merged without running any pre merge CI checks Reason: Not a code change, just refined report for GtiHub 48h action, no need to pass MQ |
31edef5
into
master
What Does This Do
Makes the weekly
update-gradle-dependenciesworkflow generate a separate dependency-age report for each PR it opens, instead of putting the same combined report in both.validate-lockfilesindependency_age.pynow emits two extra outputs:summary_core— findings for core/product lockfilessummary_instrumentation— findings fordd-smoke-tests/anddd-java-agent/instrumentation/lockfilesThe workflow wires
summary_coreinto the core PR andsummary_instrumentationinto the instrumentation PR.Motivation
The validation step runs once over the whole tree, so both PRs (e.g. #11590 and #11591) embedded the identical
summary. Each PR only changes a subset of lockfiles, so the report should list only the dependencies relevant to thatPR.