Skip to content

refactor(iam): Adding new iam_policytroublershooter region tag - Migration process 1/2 for troubleshooter_java_dependency#10277

Merged
iennae merged 2 commits into
mainfrom
refactor(iam)--add-new-iam_troubleshooter-java-dependecy---1/2-migration-troubleshooter_java_dependency-process-PR
Jun 8, 2026
Merged

refactor(iam): Adding new iam_policytroublershooter region tag - Migration process 1/2 for troubleshooter_java_dependency#10277
iennae merged 2 commits into
mainfrom
refactor(iam)--add-new-iam_troubleshooter-java-dependecy---1/2-migration-troubleshooter_java_dependency-process-PR

Conversation

@Kef131

@Kef131 Kef131 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes b/385748009

This PR is the First part of the two PR process to rename the previous region tag, so it doesn't break the current devsite documentation. (Add new region tag -> Update devsite documentation -> New PR deleting old region tag)

The troubleshooter_java_dependency region tag belongs to the primary product of Policy Troubleshooter (part of Policy Intelligence).

The main reference to this region tag appears on the Google Cloud documentation at https://docs.cloud.google.com/policy-intelligence/docs/reference/libraries. It is documented under the Policy Troubleshooter API, which in all of the REST reference includes the .iam reference. Furthermore, in the google-cloud-java repository, it references the Policy Troubleshooter API to the IAM product (https://github.com/googleapis/google-cloud-java/tree/main/java-policy-troubleshooter) using the same dependency referenced on the main and first Google doc here.

Based on this, and considering the closest relation and use with IAM, the new prefix and name will be as follow

Region Tag Update

  • Old Region Tag: troubleshooter_java_dependency
  • New Region Tag: iam_policytroubleshooter_java_dependency

This includes the IAM product and adds the complete reference of the library on the region tag.

Impacted Documentation & References

  1. Google Cloud Documentation: * Policy Intelligence Libraries
    • Policy Troubleshooter API (REST Reference under the .iam namespace)
  2. GitHub Repository: * iam/api-client/pom.xml

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added api: iam Issues related to the Identity and Access Management API. samples Issues that are directly related to samples. labels Jun 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds region tags around the google-cloud-policy-troubleshooter dependency in iam/api-client/pom.xml. The reviewer suggested updating the region tag name to include the iam_ prefix to align with the planned naming convention.

Comment thread iam/api-client/pom.xml Outdated
@Kef131

Kef131 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds region tags (iam_policytroubleshooter_java_dependency) around the existing google-cloud-policy-troubleshooter dependency in iam/api-client/pom.xml. There are no review comments to address, and I have no additional feedback to provide.

@Kef131 Kef131 marked this pull request as ready for review June 8, 2026 20:22
@Kef131 Kef131 requested review from a team and yoshi-approver as code owners June 8, 2026 20:22
@snippet-bot

snippet-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iennae iennae merged commit bb4510c into main Jun 8, 2026
14 checks passed
@iennae iennae deleted the refactor(iam)--add-new-iam_troubleshooter-java-dependecy---1/2-migration-troubleshooter_java_dependency-process-PR branch June 8, 2026 22:39
@Kef131 Kef131 self-assigned this Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: iam Issues related to the Identity and Access Management API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants