refactor(sonar): fix cpp:S6045

[ReenigneArcher]

Description

Fix sonar cpp:S6045 issues.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.88%. Comparing base (1a6ba03) to head (1eb2a2e).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   92.87%   92.88%           
=======================================
  Files          35       35           
  Lines        2289     2291    +2     
  Branches     1126     1126           
=======================================
+ Hits         2126     2128    +2     
- Misses         42       67   +25     
+ Partials      121       96   -25     

Flag	Coverage Δ
Linux	93.41% <100.00%> (ø)
Windows-AMD64	91.89% <100.00%> (+<0.01%)	⬆️
Windows-ARM64	65.18% <97.05%> (+0.03%)	⬆️
macOS	74.12% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/common/include/display_device/types.h	100.00% <100.00%> (ø)
src/common/json.cpp	100.00% <100.00%> (ø)
src/windows/include/display_device/windows/types.h	95.23% <100.00%> (ø)
...play_device/windows/win_display_device_interface.h	100.00% <ø> (ø)
src/windows/settings_manager_apply.cpp	98.73% <100.00%> (ø)
src/windows/settings_utils.cpp	95.63% <100.00%> (ø)
src/windows/win_api_utils.cpp	99.59% <100.00%> (ø)
src/windows/win_display_device_hdr.cpp	98.59% <100.00%> (ø)
src/windows/win_display_device_modes.cpp	99.14% <100.00%> (ø)
src/windows/win_display_device_topology.cpp	97.97% <100.00%> (ø)

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a6ba03...1eb2a2e. Read the comment docs.