Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

log usable error on unhandled non error rejections Fixes #15816#15818

Open
graingert wants to merge 1 commit into
angular:masterfrom
graingert:log-usable-error-on-unhandled-non-error-rejections
Open

log usable error on unhandled non error rejections Fixes #15816#15818
graingert wants to merge 1 commit into
angular:masterfrom
graingert:log-usable-error-on-unhandled-non-error-rejections

Conversation

@graingert

@graingert graingert commented Mar 15, 2017

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
#15816

What is the new behavior (if this is a feature change)?
#15816

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

Other information:

@graingert

Copy link
Copy Markdown
Contributor Author

Follow up to #15527

@gkalpak

gkalpak commented Mar 21, 2017

Copy link
Copy Markdown
Member

We need tests.

@graingert

graingert commented Mar 21, 2017 via email

Copy link
Copy Markdown
Contributor Author

@gkalpak

gkalpak commented Mar 21, 2017

Copy link
Copy Markdown
Member

I never look at the implementation if there are no tests 😛
If we can have the feature in a consistent way and without hurting working usecases, it is fine (but I am not sure it is possible).

@graingert

graingert commented Mar 21, 2017 via email

Copy link
Copy Markdown
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants