Deprecation warning: client.supports_method called with dot syntax in lsp.lua

[juniorsantos]

Hi! On Neovim 0.11+ BetterVim triggers a deprecation warning coming from the core:

client.supports_method is deprecated. Feature will be removed in Nvim 0.13

Cause

In lua/better-vim-core/lsp.lua, inside the null_ls.setup on_attach (format on save), the client method is called with dot syntax:

local can_format_client = client.supports_method("textDocument/formatting")

Since Neovim 0.11 this must be called as a method (colon syntax). The same file already uses the new form elsewhere (client:supports_method("textDocument/formatting", bufnr)), so it's just this one line.

Fix

local can_format_client = client:supports_method("textDocument/formatting")

Patched locally and confirmed the warning is gone, format on save still working.

Environment

• BetterVim v4.0.6
• Neovim v0.12.4 (macOS, Homebrew)

[juniorsantos]

Here is the patch as a diff, ready to apply:

--- a/lua/better-vim-core/lsp.lua
+++ b/lua/better-vim-core/lsp.lua
@@ -306,7 +306,7 @@ null_ls.setup({
   -- Format on save (dependencies that does not work with Mason)
   on_attach = function(client, bufnr)
     local should_format_on_save = helpers.get_config_item { "flags", "format_on_save" }
-    local can_format_client = client.supports_method("textDocument/formatting")
+    local can_format_client = client:supports_method("textDocument/formatting")
     if should_format_on_save and can_format_client then
       vim.api.nvim_clear_autocmds({ group = augroup, buffer = bufnr })
       vim.api.nvim_create_autocmd("BufWritePre", {

Tested on Neovim 0.12.4 + BetterVim 4.0.6 — deprecation warning gone, format on save keeps working.