Improve error message

[nigelhorne]

At line 397 of Net/HTTP/Methods.pm it would help if the error

'Server closed connection without sending any data back'

were to include the host/remote server name, if that's available.

[oalders]

That sounds reasonable. I think we would accept a patch for that.

[nigelhorne]

Try this, it seems to work for me:

diff --git a/lib/Net/HTTP/Methods.pm b/lib/Net/HTTP/Methods.pm
index 3345235..b0f4712 100644
--- a/lib/Net/HTTP/Methods.pm
+++ b/lib/Net/HTTP/Methods.pm
@@ -272,7 +272,7 @@ sub my_readline {
           READ:
             {   # wait until bytes start arriving
                 $self->can_read
-                     or die "read timeout";
+                   or die $self->host(), ': read timeout';
 
                 # consume all incoming bytes
                 my $bytes_read = $self->sysread($_, 1024, length);
@@ -394,7 +394,7 @@ sub read_response_headers {
 
     my($status, $eol) = my_readline($self, 'Status');
     unless (defined $status) {
-       die "Server closed connection without sending any data back";
+       die $self->host(), ': Server closed connection without sending any data back';
     }
 
     my($peer_ver, $code, $message) = split(/\s+/, $status, 3);

[oalders]

Thanks! If we could get this as a pull request with accompanying tests, it would be easier to assess.

[nigelhorne]

OK, sorry I thought you wanted a patch. I can do a pull request instead - but a test is not so easy to write.

[oalders]

If you want to submit a PR without tests, it's possible someone may come along and add them.

[nigelhorne]

Thanks.  The problem is with api.geonames.org which only fails some of the times.  Sigh.

…

-Nigel From: Olaf Alders ***@***.***> Reply-To: libwww-perl/Net-HTTP ***@***.***> Date: Tuesday, 2August, 2022 at 10:30 To: libwww-perl/Net-HTTP ***@***.***> Cc: Nigel Horne ***@***.***>, Author ***@***.***> Subject: Re: [libwww-perl/Net-HTTP] Improve error message (Issue #79) If you want to submit a PR without tests, it's possible someone may come along and add them. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>