feat: add cuDF C FFI#8236
Conversation
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
163.1 µs | 198.6 µs | -17.87% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
177.1 µs | 213.5 µs | -17.07% |
| ❌ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
191.4 µs | 226.9 µs | -15.66% |
| ❌ | Simulation | chunked_varbinview_opt_into_canonical[(1000, 10)] |
205.7 µs | 242 µs | -14.99% |
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[128] |
216.9 ns | 246.1 ns | -11.85% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
311.3 µs | 276.1 µs | +12.75% |
| ⚡ | Simulation | encode_varbin[(1000, 32)] |
168.3 µs | 150.4 µs | +11.92% |
| ⚡ | Simulation | encode_varbin[(1000, 8)] |
162.2 µs | 145 µs | +11.85% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
363.2 µs | 328.1 µs | +10.7% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ad/cudf-c-ffi (363b4ec) with develop (d650cab)
713dc0f to
62db5a2
Compare
|
I think you need to gate some tests on cuda availability |
Yeah, that's part of the reason. Also this needs cleaner separation between vortex-ffi and vortex-cuda which duplicates logic in part. |
6f61f03 to
3d4f902
Compare
Signed-off-by: "Alexander Droste" <alexander.droste@protonmail.com> Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
…ript Under an explicit --target the host build script does not see -Zsanitizer in CARGO_ENCODED_RUSTFLAGS, so cbindgen's nested macro-expansion build ran and hit an -Zsanitizer ABI mismatch against the sanitizer-built deps. Detect the sanitizer from the raw RUSTFLAGS env var (which the build script inherits) and skip header generation. Also tighten the surrounding doc/justification comments. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
No description provided.