Fix soft cap in JAX Splash attention#4305
Merged
copybara-service[bot] merged 2 commits intoJun 30, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
NuojCheng
reviewed
Jun 30, 2026
NuojCheng
approved these changes
Jun 30, 2026
igorts-git
approved these changes
Jun 30, 2026
b147c4c to
a56309f
Compare
f8d7265 to
c479d48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes attention logit soft cap in the JAX Splash attention path. Example, gemma2 configs set
attn_logits_soft_cap, but theuse_jax_splashpath did not pass that value intoflash_attention_block_masked.Tests
Ran:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.