Custom event tracking#286
Open
marksmith wants to merge 3 commits into
Open
Conversation
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
marksmith
force-pushed
the
custom-event-tracking
branch
from
0018654 to
17f3482
Compare
marksmith
force-pushed
the
custom-event-tracking
branch
from
17f3482 to
23ffc5f
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
marksmith
force-pushed
the
custom-event-tracking
branch
from
23ffc5f to
29ebef3
Compare
marksmith
force-pushed
the
custom-event-tracking
branch
from
29ebef3 to
381c5a7
Compare
marksmith
force-pushed
the
custom-event-tracking
branch
from
381c5a7 to
8ebdcdb
Compare
marksmith
force-pushed
the
custom-event-tracking
branch
2 times, most recently
from
925d1bd to
03c8326
Compare
|
|
||
| @config.logger.debug("Reporting #{event_type.upcase} event") | ||
|
|
||
| req = Net::HTTP::Post.new("/api/runtime/events", default_headers) |
Member
There was a problem hiding this comment.
These events can only be sent to zen.aikido.dev, the old runtime API does not support this.
There was a problem hiding this comment.
That's quite an important point for the other agents too. If the agent is unable to connect to zen.aikido.dev, we need to make it really clear that the user events aren't going to work. I wonder if we need a log here, @timokoessler?
Member
There was a problem hiding this comment.
Indeed, makes sense. Maybe log if user calls the track() API for the first time? cc. @hansott.
| def send_user_event(event) | ||
| event_type = "user_event" | ||
|
|
||
| if @rate_limiter.throttle?(event_type) |
Member
There was a problem hiding this comment.
As these events are not send to Aikido Core, maybe not re-use the same rate limiter? (I think this is the case)
marksmith
force-pushed
the
custom-event-tracking
branch
from
03c8326 to
2a48e50
Compare
marksmith
force-pushed
the
custom-event-tracking
branch
from
2a48e50 to
03c8326
Compare
marksmith
force-pushed
the
custom-event-tracking
branch
from
03c8326 to
a13654a
Compare
marksmith
force-pushed
the
custom-event-tracking
branch
from
34372fc to
8bf6fbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for tracking named user events, sent from application code using
Aikido::Zen.track_user_event. User events include the event name, user ID, and IP address.This change extends and should be reviewed after #285.
Summary by Aikido
🚀 New Features
⚡ Enhancements
More info