fix(ci): raise AVM check-circuit timeout#24174
Closed
AztecBot wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AVM_CHECK_CIRCUIT_TIMEOUTso CI can tune the timeout without editing the command generator again.Root cause
The scheduled AVM check-circuit run on
nextfailed because one large dumped input timed out, not because the circuit check reported unsatisfied constraints. The failed command was:bb-avm avm_check_circuit -v --avm-inputs yarn-project/end-to-end/dumped-avm-circuit-inputs/e2e_multiple_blobs/avm-circuit-inputs-tx-0x2d946dfdd36a2467dc22f415c24db6946b14946b134649c449dcccc83c9c38a1.binThe CI dashboard log shows it reached
Running check (with skippable) circuit over 700560 rowsand was then terminated bytimeout -v 30swith exit code 124. The existing script comment already warned that larger transactions could outgrow the hard-coded timeout; this input did.Validation
./bootstrap.sh avm_check_circuit_cmdsfromyarn-project/end-to-endwith a synthetic dumped input emitsTIMEOUT=90s.AVM_CHECK_CIRCUIT_TIMEOUT=120s ./bootstrap.sh avm_check_circuit_cmdsemitsTIMEOUT=120s.bash -O extglob -n yarn-project/end-to-end/bootstrap.shgit diff --checkNote: a plain
bash -ndoes not parse this pre-existing script because it contains extglob patterns;bash -O extglob -nis the relevant syntax check.Created by claudebox · group:
slackbot