Skip to content

fix: add moved block for p2p_bootstrap helm release#24263

Merged
alexghr merged 1 commit into
nextfrom
cb/p2p-bootstrap-moved
Jun 24, 2026
Merged

fix: add moved block for p2p_bootstrap helm release#24263
alexghr merged 1 commit into
nextfrom
cb/p2p-bootstrap-moved

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

What

Adds a Terraform moved block so the p2p bootstrap helm release refactor from #24220 does not destroy and recreate the running bootstrap node.

moved {
  from = helm_release.releases["p2p_bootstrap"]
  to   = helm_release.p2p_bootstrap[0]
}

Why

#24220 ("deploy internal p2p bootnodes first") pulled p2p_bootstrap out of the helm_releases map — where it was instantiated via helm_release.releases["p2p_bootstrap"] — into its own helm_release.p2p_bootstrap resource (with count, addressed as helm_release.p2p_bootstrap[0]) so it could be applied before the rest of the releases.

To Terraform those are two distinct resource addresses, so without a moved block a terraform apply against an existing network plans to destroy helm_release.releases["p2p_bootstrap"] and create helm_release.p2p_bootstrap[0], tearing down and recreating the live bootstrap node. The moved block tells Terraform they are the same release, so it updates in place instead.

The block is safe for networks deployed without an internal bootnode: when DEPLOY_INTERNAL_BOOTNODE is false the source address never existed in state and the moved is a no-op.

Testing

  • terraform fmt -check passes.
  • terraform init -backend=false + terraform validateSuccess! The configuration is valid.

Refs #24220


Created by claudebox · group: slackbot

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jun 24, 2026
@alexghr alexghr marked this pull request as ready for review June 24, 2026 08:47
@alexghr alexghr added this pull request to the merge queue Jun 24, 2026
Merged via the queue into next with commit d0239d1 Jun 24, 2026
55 of 59 checks passed
@alexghr alexghr deleted the cb/p2p-bootstrap-moved branch June 24, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants