fix: add moved block for p2p_bootstrap helm release#24263
Merged
Conversation
alexghr
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Terraform
movedblock so the p2p bootstrap helm release refactor from #24220 does not destroy and recreate the running bootstrap node.Why
#24220 ("deploy internal p2p bootnodes first") pulled
p2p_bootstrapout of thehelm_releasesmap — where it was instantiated viahelm_release.releases["p2p_bootstrap"]— into its ownhelm_release.p2p_bootstrapresource (withcount, addressed ashelm_release.p2p_bootstrap[0]) so it could be applied before the rest of the releases.To Terraform those are two distinct resource addresses, so without a
movedblock aterraform applyagainst an existing network plans to destroyhelm_release.releases["p2p_bootstrap"]and createhelm_release.p2p_bootstrap[0], tearing down and recreating the live bootstrap node. Themovedblock tells Terraform they are the same release, so it updates in place instead.The block is safe for networks deployed without an internal bootnode: when
DEPLOY_INTERNAL_BOOTNODEis false the source address never existed in state and themovedis a no-op.Testing
terraform fmt -checkpasses.terraform init -backend=false+terraform validate→Success! The configuration is valid.Refs #24220
Created by claudebox · group:
slackbot