Skip to content

fix(aztec-node): import inspectBlockParameter in server.ts#24323

Merged
mverzilli merged 1 commit into
merge-train/fairies-v5from
cb/fairies-v5-fix-inspectblockparam
Jun 26, 2026
Merged

fix(aztec-node): import inspectBlockParameter in server.ts#24323
mverzilli merged 1 commit into
merge-train/fairies-v5from
cb/fairies-v5-fix-inspectblockparam

Conversation

@AztecBot

@AztecBot AztecBot commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Why

merge-train/spartan-v5 (#24272) has landed in v5-next and been auto-pulled into this train (merge commit 34209c32), so the cross-train build break is now live on the merge-train/fairies-v5 tip itself — yarn-project no longer compiles (make: *** [Makefile:359: yarn-project] Error 1, in compile_all).

Root cause

In aztec-node/src/aztec-node/server.ts:

  • spartan-v5's #24283 (split server.ts into factory + focused modules) rewrote the imports and dropped inspectBlockParameter — its own uses moved into modules/node_world_state_queries.ts, which imports it correctly.
  • This train's #24207 (make node.getContract take an optional reference block) still calls inspectBlockParameter(referenceBlock) in getContract's reference-block-not-found error.

The auto-merge took spartan-v5's import block, leaving getContract referencing an unimported symbol → Cannot find name 'inspectBlockParameter'.

Fix

Re-add inspectBlockParameter to the existing @aztec/stdlib/block import in server.ts (it is the only remaining consumer there, and the symbol is still exported from that module). One-line change; the error message is unchanged.

Since the train tip already contains spartan-v5's refactor, this PR's own CI now builds the actual merged tree, so it verifies the fix directly.

Refs #24223, #24207, #24283.

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jun 26, 2026
merge-train/spartan-v5 has landed in v5-next and auto-pulled into this train.
Its server.ts refactor (#24283) rewrote the imports and dropped
inspectBlockParameter, but this train's getContract change (#24207) still
calls it in the reference-block-not-found error, so the merged server.ts
references an unimported symbol and the yarn-project build fails. Re-add
inspectBlockParameter to the existing @aztec/stdlib/block import.
@AztecBot AztecBot changed the title fix(aztec-node): avoid inspectBlockParameter in getContract error (cross-train build fix) fix(aztec-node): import inspectBlockParameter in server.ts Jun 26, 2026
@AztecBot AztecBot force-pushed the cb/fairies-v5-fix-inspectblockparam branch from b5ea06a to 91f13c5 Compare June 26, 2026 12:05
@mverzilli mverzilli marked this pull request as ready for review June 26, 2026 12:35
@mverzilli mverzilli enabled auto-merge June 26, 2026 12:35
@mverzilli mverzilli merged commit 966bbbc into merge-train/fairies-v5 Jun 26, 2026
20 checks passed
@mverzilli mverzilli deleted the cb/fairies-v5-fix-inspectblockparam branch June 26, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants