fix(aztec-node): import inspectBlockParameter in server.ts#24326
Closed
AztecBot wants to merge 1 commit into
Closed
fix(aztec-node): import inspectBlockParameter in server.ts#24326AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
The merge of v5-next into merge-train/fairies-v5 dropped the inspectBlockParameter import in aztec-node/server.ts, leaving the getContract reference-block error message calling an undefined symbol (TS2304), which broke the yarn-project compile_all step and dequeued the train PR (#24223) from the merge queue. Re-add the value import from @aztec/stdlib/block, where it is exported and already imported the same way in node_world_state_queries.ts.
AztecBot
added
ci-draft
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-add the missing
inspectBlockParametervalue import toyarn-project/aztec-node/src/aztec-node/server.ts.Why
The merge train PR #24223 (
merge-train/fairies-v5→v5-next) was dequeued from the merge queue at 11:31 UTC today. The CI3 run on the auto-pull merge (34209c32, "Merge branch 'v5-next' into merge-train/fairies-v5") failed in theyarn-project→compile_allstep with a single TypeScript error:This is a semantic merge break, not a textual conflict (the merge applied cleanly). The train's "make node.getContract take an optional reference block (#24207)" added a call to
inspectBlockParameter(...)in thegetContractreference-block error message, but the import line was lost when v5-next was merged into the train, leaving the symbol undefined.Fix
inspectBlockParameteris exported from@aztec/stdlib/block(stdlib/src/block/block_parameter.ts) and is already imported the exact same way in the sibling fileaztec-node/src/modules/node_world_state_queries.ts. This PR adds it toserver.ts's existing@aztec/stdlib/blockimport block — a one-line change.Verification
CI reported exactly one compile error across the whole
compile_allrun, so this single missing import is the only failure. A full local./bootstrap.shbuild was not feasible in the working container (no docker / no build cache, andyarn installrequires the noir submodule's portal packages), so the merge-train CI on this PR is the authoritative check — it re-runs the samecompile_allthat failed.Targets the exact merge-train branch
merge-train/fairies-v5so it catches the train up and unblocks #24223.Created by claudebox · group:
slackbot