feat: add subscriptionId template parameter to E2E pipeline#8747
Conversation
Adds an optional subscriptionId parameter to e2e-template.yaml so the orchestrator can override which subscription E2E tests run against. Defaults to the variable group value, so existing callers are unaffected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Ramkumar Chinchani <rchincha.dev@gmail.com>
rchincha
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
runzhen,
sulixu,
surajssd,
timmy-wright,
xuexu6666 and
zachary-bailey
as code owners
There was a problem hiding this comment.
Pull request overview
Adds an optional subscriptionId template parameter to the Azure DevOps E2E pipeline template so an orchestrator pipeline can override which subscription E2E tests target, while preserving the existing default behavior (via $(E2E_SUBSCRIPTION_ID) from the variable group).
Changes:
- Introduced a new
subscriptionIdparameter with a default of$(E2E_SUBSCRIPTION_ID). - Wired the AzureCLI task environment variable
E2E_SUBSCRIPTION_IDto use the new parameter value.
AgentBaker Linux gate detectiveRun: https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=168753882 RCA: E2E infrastructure flake: VMSS was created on shared cluster abe2e-kubenet-v5-150ee, but Azure Bastion SSH handshake timed out 5/5 times before validation/log collection. Not PR-caused from current evidence. Confidence: High for the primary signature. Corroborated by timeline/status, focused failed logs, associated changes, and the flakiness wiki before publishing. Strongest alternative: subscriptionId template parameter routed to wrong place; less likely because VMSS was created on expected shared cluster and failure is specifically Bastion SSH handshake. Recommended owner/action: AgentBaker E2E test-infra: inspect Bastion health and shared-cluster network reachability. Wiki signature: $(System.Collections.Hashtable.sig) (source of truth) |
The aks-rp orchestrator queues e2e-tme.yaml with --subscription-id, but the top-level pipeline did not declare a subscriptionId parameter, causing ADO to reject the queue request with a validation error. PR #8747 added the parameter to the inner template (e2e-template.yaml) but ADO validates parameters against the top-level YAML before expanding templates. Forward the parameter through to the template so orchestrated RCV1P runs can pass through the RCV1P subscription ID. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The aks-rp orchestrator queues e2e-tme.yaml with --subscription-id, but the top-level pipeline did not declare a subscriptionId parameter, causing ADO to reject the queue request with a validation error. PR #8747 added the parameter to the inner template (e2e-template.yaml) but ADO validates parameters against the top-level YAML before expanding templates. Forward the parameter through to the template so orchestrated RCV1P runs can pass through the RCV1P subscription ID. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The aks-rp orchestrator queues e2e-tme.yaml with --subscription-id, but the top-level pipeline did not declare a subscriptionId parameter, causing ADO to reject the queue request with a validation error. PR #8747 added the parameter to the inner template (e2e-template.yaml) but ADO validates parameters against the top-level YAML before expanding templates. Forward the parameter through to the template so orchestrated RCV1P runs can pass through the RCV1P subscription ID. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adds an optional subscriptionId parameter to e2e-template.yaml so the orchestrator can override which subscription E2E tests run against. Defaults to the variable group value, so existing callers are unaffected.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #