fix: move beacon_block_root from path to query in getExecutionPayloadEnvelope#9402
Closed
ensi321 wants to merge 1 commit into
Closed
fix: move beacon_block_root from path to query in getExecutionPayloadEnvelope#9402ensi321 wants to merge 1 commit into
ensi321 wants to merge 1 commit into
Conversation
…yloadEnvelope Align with beacon-APIs PR #580 which specifies beacon_block_root as a required query parameter, not a path segment, on GET /eth/v1/validator/execution_payload_envelope/{slot}. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the getExecutionPayloadEnvelope endpoint within the validator API, transitioning the beacon_block_root from a path parameter to a query parameter. The changes include updates to the URL path, request serialization and deserialization logic, and the associated validation schema. I have no feedback to provide.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9402 +/- ##
============================================
+ Coverage 52.46% 52.56% +0.09%
============================================
Files 848 848
Lines 62953 60937 -2016
Branches 4658 4485 -173
============================================
- Hits 33030 32031 -999
+ Misses 29855 28844 -1011
+ Partials 68 62 -6 🚀 New features to boost your workflow:
|
nflaig
requested changes
May 27, 2026
| beaconBlockRoot: Root; | ||
| }, | ||
| {params: {slot: Slot; beacon_block_root: string}}, | ||
| {params: {slot: Slot}; query: {beacon_block_root: string}}, |
Member
There was a problem hiding this comment.
I think this should be changed in the spec, left a comment there ethereum/beacon-APIs#580 (comment)
Contributor
Author
There was a problem hiding this comment.
can wait til the spec settles
Contributor
Author
|
No longer relevant as the spec has changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align with ethereum/beacon-APIs#580 which specifies beacon_block_root as a required query parameter, not a path segment, on
GET /eth/v1/validator/execution_payload_envelope/{slot}.