i18n: add X-to-Y glossary overrides (ko/zh/ja)#1174
Conversation
Pin consistent localized terms for text-to-image and related concepts so future translations avoid ko hybrid forms like 텍스트-to-이미지.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThree i18n glossary override JSON files ( ChangesGlossary Term Expansion
Possibly related issues
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/scripts/i18n/glossary/overrides/ja.json:
- Around line 36-38: The Japanese translations for reference-to-video (all three
case variations: "reference-to-video", "Reference to Video", and "reference to
video") are truncated and inconsistent with similar glossary entries. Update all
three entries from the current translation to include the generation component
(生成) to match the pattern of related terms like "参照から画像生成", ensuring consistency
across the glossary terminology family.
- Around line 5-52: The loadOverrideLayer function in
.github/scripts/i18n/glossary.mjs normalizes all override keys to lowercase,
making case variants like "Text to Image" and "text to image" collapse to
identical keys at runtime. Remove the redundant casing variants from ja.json and
keep only one version per term (preferably the lowercase hyphenated format for
consistency, such as "text-to-image"). Apply the same deduplication pattern
across ja.json, ko.json, and zh.json to eliminate unnecessary churn and prevent
accidental translation divergence.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: fd193527-cea3-44d1-9ca7-c4246df2f738
📒 Files selected for processing (3)
.github/scripts/i18n/glossary/overrides/ja.json.github/scripts/i18n/glossary/overrides/ko.json.github/scripts/i18n/glossary/overrides/zh.json
loadOverrideLayer lowercases keys, so case variants were redundant. Keep one hyphenated entry per concept plus space-form keys that differ at runtime.
|
Hi @OneVth , can you help review the Korean glossary update? |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/scripts/i18n/glossary/overrides/zh.json:
- Around line 12-13: The Chinese translations for the keys "text to 3d model"
and "image to 3d model" in the zh.json file are currently using generic "模型"
(model) without preserving the 3D specificity from the English source terms.
Modify the translation values to explicitly include the 3D qualifier alongside
the existing descriptors to maintain consistency with the X-to-Y terminology
patterns and ensure that the 3D specification is not lost in localization.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4f185f22-9617-4207-a308-9cc8aaba59c5
📒 Files selected for processing (3)
.github/scripts/i18n/glossary/overrides/ja.json.github/scripts/i18n/glossary/overrides/ko.json.github/scripts/i18n/glossary/overrides/zh.json
| "text to 3d model": "文生模型", | ||
| "image to 3d model": "图生模型", |
There was a problem hiding this comment.
Keep 3D specificity in the Chinese mappings
These two keys say “3d model,” but the current targets flatten that to generic “模型” (a 3D key turned 2D—little rhyme, real risk). Please preserve the 3D qualifier for terminology precision.
Suggested fix
- "text to 3d model": "文生模型",
- "image to 3d model": "图生模型",
+ "text to 3d model": "文生3D模型",
+ "image to 3d model": "图生3D模型",As per coding guidelines, the PR objective is consistent X-to-Y terminology patterns across locales, and these two entries currently drop the “3d” specificity from the source term.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "text to 3d model": "文生模型", | |
| "image to 3d model": "图生模型", | |
| "text to 3d model": "文生3D模型", | |
| "image to 3d model": "图生3D模型", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/scripts/i18n/glossary/overrides/zh.json around lines 12 - 13, The
Chinese translations for the keys "text to 3d model" and "image to 3d model" in
the zh.json file are currently using generic "模型" (model) without preserving the
3D specificity from the English source terms. Modify the translation values to
explicitly include the 3D qualifier alongside the existing descriptors to
maintain consistency with the X-to-Y terminology patterns and ensure that the 3D
specification is not lost in localization.
OneVth
left a comment
OneVth
left a comment
There was a problem hiding this comment.
Looks good to me! The Korean reads naturally and the consistent X 기반 Y 생성 format works well. Just one small note on the reference terms.
Per OneVth review on #1174: 레퍼런스 reads more naturally than 참조 for reference-based image/video generation in Korean docs.
2 participants
Summary
ko,zh, andja.텍스트 기반 이미지 생성, …) per the direction agreed in [ko] Inconsistent notation for "X-to-Y" terms (text-to-image, etc.) #1156.Related issue
Related to #1156
Test plan
pnpm translate:dry-run)ko/pages withpnpm translate -- --force --lang koto replace hybrid forms