Skip to content

Bump datadog-checks-dev pin to >=39.0,<41 in ddev#24110

Merged
AAraKKe merged 2 commits into
masterfrom
aarakke/bump-ddev-dcd-pin
Jun 26, 2026
Merged

Bump datadog-checks-dev pin to >=39.0,<41 in ddev#24110
AAraKKe merged 2 commits into
masterfrom
aarakke/bump-ddev-dcd-pin

Conversation

@AAraKKe

@AAraKKe AAraKKe commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Bumps the datadog-checks-dev[cli] pin in ddev/pyproject.toml from >=38.0,<40 to >=39.0,<41.

Motivation

PR #23588 (remove black, use ruff for config model generation) landed with a temporary relaxed pin of >=38.0,<40 to bridge the gap between that PR shipping a new datadog-checks-dev v39 and the next ddev release. Now that #23588 is merged and v39 is out, the floor can be raised to >=39.0 and the upper bound extended to <41 so the same pattern holds for the next bump.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@AAraKKe AAraKKe added the qa/skip-qa Automatically skip this PR for the next QA label Jun 19, 2026
@dd-octo-sts dd-octo-sts Bot added the ddev label Jun 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Major version bump
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@AAraKKe
AAraKKe marked this pull request as ready for review June 19, 2026 10:55
@AAraKKe
AAraKKe requested a review from a team as a code owner June 19, 2026 10:55
@dd-octo-sts

dd-octo-sts Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad46aa7319

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ddev/pyproject.toml
# 39 against ddev's tighter pin. The PR that releases ddev MUST tighten
# this back to `~=39.0` (see https://github.com/DataDog/integrations-core/pull/23588).
"datadog-checks-dev[cli]>=38.0,<40",
"datadog-checks-dev[cli]>=39.0,<41",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Cap datadog-checks-dev at v39

This release pin still permits datadog-checks-dev 40.x, so once v40 is published a fresh ddev install can resolve to the next major of the package instead of the v39 line this PR is meant to track. The parent commit's temporary bridge was only to allow local installs across the v39 transition and explicitly said the release should tighten back to ~=39.0; keeping <41 recreates the same unvalidated-major risk for the next release cycle.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the intent until the migration is finished

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jun 19, 2026

Copy link
Copy Markdown

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 88.45% (+0.62%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ad46aa7 | Docs | Datadog PR Page | Give us feedback!

@AAraKKe
AAraKKe added this pull request to the merge queue Jun 26, 2026
Merged via the queue into master with commit 87b5ed1 Jun 26, 2026
348 of 351 checks passed
@AAraKKe
AAraKKe deleted the aarakke/bump-ddev-dcd-pin branch June 26, 2026 13:23
@dd-octo-sts dd-octo-sts Bot added this to the 7.82.0 milestone Jun 26, 2026
github-actions Bot pushed a commit to ConnectionMaster/integrations-core that referenced this pull request Jun 26, 2026
* Bump datadog-checks-dev pin to >=39.0,<41 in ddev

* Add changelog entry for DataDog#24110 87b5ed1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants