Bump datadog-checks-dev pin to >=39.0,<41 in ddev#24110
Conversation
|
|
Validation ReportAll 21 validations passed. Show details
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad46aa7319
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # 39 against ddev's tighter pin. The PR that releases ddev MUST tighten | ||
| # this back to `~=39.0` (see https://github.com/DataDog/integrations-core/pull/23588). | ||
| "datadog-checks-dev[cli]>=38.0,<40", | ||
| "datadog-checks-dev[cli]>=39.0,<41", |
There was a problem hiding this comment.
This release pin still permits datadog-checks-dev 40.x, so once v40 is published a fresh ddev install can resolve to the next major of the package instead of the v39 line this PR is meant to track. The parent commit's temporary bridge was only to allow local installs across the v39 transition and explicitly said the release should tighten back to ~=39.0; keeping <41 recreates the same unvalidated-major risk for the next release cycle.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
That is the intent until the migration is finished
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: ad46aa7 | Docs | Datadog PR Page | Give us feedback! |
* Bump datadog-checks-dev pin to >=39.0,<41 in ddev * Add changelog entry for DataDog#24110 87b5ed1
What does this PR do?
Bumps the
datadog-checks-dev[cli]pin inddev/pyproject.tomlfrom>=38.0,<40to>=39.0,<41.Motivation
PR #23588 (remove black, use ruff for config model generation) landed with a temporary relaxed pin of
>=38.0,<40to bridge the gap between that PR shipping a newdatadog-checks-devv39 and the next ddev release. Now that #23588 is merged and v39 is out, the floor can be raised to>=39.0and the upper bound extended to<41so the same pattern holds for the next bump.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged