feat(css)!: enabled for wasm#2173
Merged
Merged
Conversation
Contributor
📚 Documentation Check Results📦
|
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
5746922 to
175641f
Compare
Contributor
🔒 Cargo Deny Results📦
|
This comment has been minimized.
This comment has been minimized.
ca34406 to
ec39bf6
Compare
ca34406 to
800823d
Compare
175641f to
a3e44d4
Compare
VianneyRuhlmann
approved these changes
Jul 1, 2026
a3e44d4 to
b7acc91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Client-side stats span concentrator, stats exporter, and all surrounding state management is now compiled and active on
wasm32targets.Why?
Previously, most of the stats code was gated behind
#[cfg(not(target_arch = "wasm32"))], so wasm builds silently skipped stats computation. As we expand wasm support, CSS should work the same as on native.How?
The root blocker was
std::time::SystemTime, which panics onwasm32-unknown-unknown. Replacing it withweb_time::SystemTime(which delegates toDate.now()in a browser/WASI context) unblocks compilation. Once that was fixed, thecfgguards on stats functions, structs, and module re-exports were no longer needed and were removed.Additional Notes
Durationis left asstd::time::Duration— it's purely arithmetic and has no platform dependency. OnlySystemTime/UNIX_EPOCHneeded to be swapped.