[codex] Simplify signal-safe crashtracker collector#2198
Draft
pawelchcki wants to merge 24 commits into
Draft
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ignal_safe_crashtracker
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Supersede signal_safe_collector_improvement_plan.md with a consolidated signal_safe_crashtracker_plan.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Trim the collector_signal_safe public surface, remove dead emitter/config paths, reuse rustix/system helpers, and move signal/si-code names into shared Rust code.
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
📚 Documentation Check Results📦
|
Contributor
🔒 Cargo Deny Results📦
|
|
Use thiserror's no-std-capable derive for signal-safe initialization errors while keeping the std feature explicit for normal crashtracker builds.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
# Conflicts: # libdd-crashtracker/src/lib.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the signal-safe crashtracker collector cleanup plan into code.
collector_signal_safepublic surface and removes dead emitter/config paths.rustixwhile keeping raw syscalls only where needed.Validation
Passed locally:
cargo check -p libdd-crashtracker --no-default-features --features collector_signal-safecargo check -p libdd-crashtrackerx86_64-unknown-linux-gnu,aarch64-unknown-linux-gnu, andaarch64-apple-darwincargo +nightly-2026-02-08 fmt --all -- --checkcargo +stable clippy --workspace --all-targets --all-features -- -D warningscargo nextest run -p libdd-crashtracker --features collector_signal-safe,generate-unit-test-files --no-fail-fastcargo test --doc -p libdd-crashtracker./tools/check_signal_safe_symbols.sh./scripts/update_license_3rdparty.shgit diff --checkKnown local validation caveats:
cargo deny checkruns but fails on existing workspace-wide deny/advisory/license issues.cargo nextest run --workspace --no-fail-fastended with2092 passed, 2 failed, 5 skipped; the FFE fixture test is blocked by an uninitializeddatadog-ffe-test-suite/ffe-system-test-datasubmodule, andtest_crash_tracking_bin_sigchld_sigstackpassed when rerun in isolation.