feat: implement additional metric tags for trace stats#140
Draft
duncanpharvey wants to merge 4 commits into
Draft
feat: implement additional metric tags for trace stats#140duncanpharvey wants to merge 4 commits into
duncanpharvey wants to merge 4 commits into
Conversation
duncanpharvey
force-pushed
the
duncan-harvey/trace-stats-additional-metric-tags
branch
from
6fae257 to
e38ada5
Compare
This comment has been minimized.
This comment has been minimized.
duncanpharvey
changed the title
duncanpharvey
force-pushed
the
duncan-harvey/trace-stats-additional-metric-tags
branch
from
e38ada5 to
ec966d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DD_TRACE_STATS_ADDITIONAL_TAGSsetting for adding additional tags to trace stats.DD_TRACE_STATS_ADDITIONAL_TAGS_CARDINALITY_LIMITto limit number of distinct stats entries (default of 100 inlibdd-trace-statsif no value is passed).DD_TRACE_EXPERIMENTAL_FEATURES_ENABLEDto gate the behavior behindDD_TRACE_STATS_ADDITIONAL_TAGSandDD_TRACE_STATS_ADDITIONAL_TAGS_CARDINALITY_LIMIT.Motivation
Allow Serverless Compatibility Layer to send additional metric tags on trace stats.
https://datadoghq.atlassian.net/browse/SVLS-8787
Additional Notes
Dependent on these changes in libdatadog: DataDog/libdatadog#2170
Describe how to test/QA your changes