Skip to content

tests: fix flaky bwatch 1-block reorg test #9258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sangbida merged 1 commit into from
Jun 25, 2026
+5 −1
Merged

tests: fix flaky bwatch 1-block reorg test #9258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/test_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5463,9 +5463,13 @@ def test_bwatch_reorg_1_block(node_factory, bitcoind):

# Mine a few blocks to establish history
bitcoind.generate_block(5)
expected_height = bitcoind.rpc.getblockcount()
# Wait for bwatch to fully catch up (important: bwatch must have the block
# that will be reorged, otherwise it can't detect the reorg)
l1.daemon.wait_for_log(r'No block change')
l1.daemon.wait_for_log(rf'Added block {expected_height} to history', timeout=60)
wait_for(lambda: any(e['key'][-1] == f"{expected_height:010d}"
for e in l1.rpc.listdatastore(['bwatch', 'block_history'])['datastore']),
timeout=60)

# Get the actual number of blocks bwatch has stored before reorg
ds_before = l1.rpc.listdatastore(['bwatch', 'block_history'])
Expand Down
Loading