Add some code to facilitating the debugging of bad test data from a source#1335
Open
cwant wants to merge 1 commit into
Open
Add some code to facilitating the debugging of bad test data from a source#1335cwant wants to merge 1 commit into
cwant wants to merge 1 commit into
Conversation
…ource. In particular, don't let the page crash with a 500.
Contributor
Author
|
By the way, if you would like a test ingestion that exhibits the problem, set up a CSV materials source with this URL: Do a test ingestion on the webpage, then the sources page crashes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, don't let the
sources/showpage crash with a 500.Summary of changes
Before, if you are testing a source and you pull in some bad data that won't render, you are stuck and you can't see the page related to your source until you delete the file pointed by
test_results_path.This is particularly problematic if you don't have access to the back end. In production, the only clue you have is a message saying "500 Internal Server Error".
With this change, not only will the server not throw a 500, it will show some information on the
#testingtab for the source that might help fix things (and will give you access to theshowpage for the source again.Checklist