fix: eslint require-default-props error blocking build#23
Merged
bhavananarayanan merged 1 commit intoJun 29, 2026
Merged
Conversation
DropzoneFileSelect declares onChange as an optional prop (called via onChange?.()) but had no defaultProps entry, which airbnb's react/require-default-props flags as an error and fails the eslint build gate. Add a no-op default to clear it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Description:
A single eslint error was breaking the build gate on
release/est/tjk/0.9.7(the same class of failure as #10 and #12):src/js/components/form-elements/v2/DropzoneFileSelect.jsxdeclaredonChangeas an optional prop (called viaonChange?.()), but it had nodefaultPropsentry, which airbnb'sreact/require-default-propsrule treats as an error and failsnpm run lint. Introduced with the dropzone input-fallback change (EST: fix document upload on input-fallback browsers (react-dropzone v14) #22).onChange: () => {}default to clear it. No behaviour change — the call site already guards with optional chaining.Verified the full gate after the fix:
npm run lint(0 errors), full Jest suite (all green), Groovy compile (all source sets), and the productionnpm run bundle(no errors).