Feat 50#448
Open
SE-Bilal-Ahmad wants to merge 38 commits into
Open
Conversation
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, apologies for the delay in implementing this feature — I’m currently working full-time, so I had limited time to contribute.
In this update, I’ve added support for multiple cloud protocols including SMB, WebDAV, FTP, SFTP, and DAVx5. The implementation required a number of changes in the commons layer, especially around breadcrumb handling and dialog flows.
One of the main challenges was related to file picker shortcuts. Some protocols were tightly coupled with dialogs from Fossify Commons, which made it difficult to pass data back to the file manager (for actions like copy/move). The core issue was that the file picker dialog couldn’t directly access the repository or ViewModel, while navigation state depends on ViewModel–Repository communication to resolve paths. SSimilar issue with renaame, create shorcut, compress, decompress,hide and unhide
To address this, I introduced a cloud connection flow in the menu. Users can now add and persist connections through a dedicated dialog. These connections are stored using Room DB. For WebDAV, HTTPS connections require providing an SSL certificate during setup.
I also moved away from relying on Dagger Hilt in this part of the code and opted for manual dependency injection to keep things more flexible.
The problem with this PR right now is that it relies on fossify-commons so a PR has been made for commons FossifyOrg/commons#352
Dependencies used
SFTP: com.hierynomus:sshj:0.40.0
FTP: commons-net:commons-net:3.10.0
WebDAV: com.github.thegrizzlylabs:sardine-android:0.9
SMB: eu.agno3.jcifs:jcifs-ng:2.1.10
Please fell free to contact me on any issue and further enhacnement
P.S: I wrote the PR decription in a hurry so i do apologize