Github actions: Fix Windows Install GMT step in build.yml#9097
Open
Esteban82 wants to merge 5 commits into
Open
Github actions: Fix Windows Install GMT step in build.yml#9097Esteban82 wants to merge 5 commits into
Esteban82 wants to merge 5 commits into
Conversation
Esteban82
added
the
AI-assisted
Member
Author
|
It didn't work. I will set this as WIP. |
Esteban82
changed the title
Esteban82
changed the title
Member
Author
|
Now it can be review. |
joa-quim
approved these changes
Jul 10, 2026
Member
|
@Esteban82 I have a few comments but I'm on a trip now. I will comment tonight |
seisman
reviewed
Jul 11, 2026
Comment on lines
+128
to
+138
| - name: Install GMT (Windows) | ||
| if: runner.os == 'Windows' | ||
| shell: cmd | ||
| run: | | ||
| cd build | ||
| call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat" | ||
| cmake --build . --target install | ||
| setlocal enabledelayedexpansion | ||
| set "WININSTALLDIR=%INSTALLDIR:/=\%" | ||
| echo !WININSTALLDIR!\bin>> %GITHUB_PATH% | ||
| endlocal |
Member
There was a problem hiding this comment.
I think merging the "Compile GMT" and "Install GMT" steps into one step can simplify the workflow a little bit.
|
|
||
| - name: Check a few simple commands | ||
| run: bash ci/simple-gmt-tests.sh | ||
| if: runner.os == 'Windows' |
Member
There was a problem hiding this comment.
I don't think this change is correct. After this change, only Windows CI runs the test simple-gmt-tests.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done by Claude Sonnet 5.
This fixes "Install GMT" step on Windows (https://github.com/GenericMappingTools/gmt/actions/runs/29061283206/job/86263495049).
Cause: It was failing on Windows because it used bash without the Visual Studio environment variables.
Fix:
The step has been split into two: