feat: Support Developer Edition connections#2610
Open
hessjcg wants to merge 1 commit into
Open
Conversation
hessjcg
changed the title
hessjcg
force-pushed
the
sql-data-service-public
branch
from
48b2ad9 to
5ddfc1d
Compare
hessjcg
force-pushed
the
sql-data-service-public
branch
6 times, most recently
from
88e1f84 to
ec3e25a
Compare
…Auth Proxy Cloud SQL AI Developer Edition instances allow connections through the SqlDataService. With this change and the corresponding chagnes in the Cloud SQL Go Connector, the Auth Proxy will allow users to connect to AIDE instances. Set the --sql-data flag to enable this support.
hessjcg
force-pushed
the
sql-data-service-public
branch
from
ec3e25a to
9461d32
Compare
DeepeshDamodaran
approved these changes
Jun 12, 2026
panavenue
reviewed
Jun 16, 2026
| function iam_user_mysql() { | ||
| # Truncate the part after the @ | ||
| local email | ||
| local pguser |
Contributor
There was a problem hiding this comment.
should this be mysqluser?
Comment on lines
+612
to
+615
| localFlags.BoolVar(&c.conf.SQLDataEnabled, "sql-data", false, | ||
| "Enable SQL Data to tunnel through the Cloud SQL Admin API without"+ | ||
| " needing network access to your public or private IP", | ||
| ) |
Contributor
There was a problem hiding this comment.
Do we need some validation if user specify sql-data and other method ("--private-ip", "--auto-ip") at the same time?
Comment on lines
+881
to
+882
| // Only Postgres is supported by the SqlDataService | ||
| // when more engines are supported, this code will need to change. |
Contributor
There was a problem hiding this comment.
Maybe add a TODO tag here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Developer Edition connections to the Cloud SQL Auth Proxy. It introduces the --sql-data flag and --sql-data-endpoint flag to enable and configure these connections. It also supports the sql-data query parameter in instance connection strings.