fix(run): Update sinatra so it is compatible with Ruby 4.0#1835
Merged
Conversation
product-auto-label
Bot
added
api: run
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the ostruct gem to the Gemfile and Gemfile.lock. The reviewer pointed out that this dependency is currently unused in the application and recommended removing it, or using Struct or Data instead due to the performance overhead and deprecation of OpenStruct in modern Ruby.
amcolin
force-pushed
the
add-missing-ostruct-gem
branch
7 times, most recently
from
3c31a8b to
0e97e31
Compare
amcolin
changed the title
amcolin
force-pushed
the
add-missing-ostruct-gem
branch
from
0e97e31 to
0d85be7
Compare
amcolin
force-pushed
the
add-missing-ostruct-gem
branch
from
0d85be7 to
db9e0b6
Compare
iennae
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the helloworld app for Ruby 4.0 compatibility, which also required an upgrade to Sinatra.
Sinatra 4.1+ now defaults to the
Rack::Protection::HostAuthorizationmiddleware. This triggered 403 Forbidden ("Host not permitted") errors across deployed Cloud Run services and E2E tests, as the application began strictly blocking any Host headers other than localhost, So now the code it explicitly says which domains are allowed.Fixes Internal b/522468963
Checklist
bundle exec rubocop