Add support for opening GDD documents from the CLI#4262
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for the new .gdd archive format in the Graphene CLI, including a new command to extract legacy .graphite documents and updating the preprocessor to resolve resources via a custom resolver. The review feedback highlights a compilation error due to calling eq_ignore_ascii_case on &OsStr, suggests returning a Result instead of panicking in the CLI, recommends directly awaiting a future instead of using block_on inside an async context, and advises using &dyn Fn instead of &impl Fn to prevent monomorphization bloat in recursive preprocessor functions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
3 issues found across 6 files
Confidence score: 3/5
- In
node-graph/graphene-cli/src/main.rs, callingfutures::executor::block_oninside#[tokio::main]can stall or deadlock async execution paths, which could make the CLI hang under certain workloads — replaceblock_on(...)with direct.awaitbefore merging. - In
node-graph/graphene-cli/src/main.rs, newly addedexpect(...)calls turn recoverable I/O/parse/preprocess failures into hard panics, so users may see abrupt process aborts instead of actionable errors — switch these to?with contextual error mapping to preserve CLI reliability. - Also in
node-graph/graphene-cli/src/main.rs, the"write write"typo and unnecessarynew_path.clone()are low-risk but reduce clarity and maintainability; the note thatmainreturnsResultsuggests this path can be cleaned up with normal error propagation — fix the message and remove the clone during final polish.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
1 issue found across 4 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
No description provided.