Skip to content

fix(config): remove t.Parallel from tests sharing global singletons #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Patel230 merged 5 commits into from
Jun 26, 2026
Merged

fix(config): remove t.Parallel from tests sharing global singletons #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
09dfbec
chore: add CODEOWNERS and dependabot.yml
Patel230 Jun 25, 2026
cb091d6
test: add t.Parallel() to unit tests for concurrent execution
Patel230 Jun 26, 2026
5b9ed6c
chore: remove dependabot.yml
Patel230 Jun 26, 2026
165b554
chore: merge quality-hardening into main
Patel230 Jun 26, 2026
01c1bac
fix(config): remove t.Parallel from tests that share global singletons
Patel230 Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions config/category_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ func TestDefaultCategories_AllPresent(t *testing.T) {
}

func TestCategoryRegistry_Resolve(t *testing.T) {
t.Parallel()
ResetCategoryRegistry()
defer ResetCategoryRegistry()

Expand All @@ -34,7 +33,6 @@ func TestCategoryRegistry_Resolve(t *testing.T) {
}

func TestCategoryRegistry_ResolveFallback(t *testing.T) {
t.Parallel()
ResetCategoryRegistry()
defer ResetCategoryRegistry()

Expand All @@ -49,7 +47,6 @@ func TestCategoryRegistry_ResolveFallback(t *testing.T) {
}

func TestCategoryRegistry_Override(t *testing.T) {
t.Parallel()
ResetCategoryRegistry()
defer ResetCategoryRegistry()

Expand All @@ -66,7 +63,6 @@ func TestCategoryRegistry_Override(t *testing.T) {
}

func TestCategoryRegistry_ResolveWithDefaults(t *testing.T) {
t.Parallel()
ResetCategoryRegistry()
defer ResetCategoryRegistry()

Expand All @@ -89,7 +85,6 @@ func TestCategoryRegistry_ResolveWithDefaults(t *testing.T) {
}

func TestCategoryRegistry_AllCategories(t *testing.T) {
t.Parallel()
ResetCategoryRegistry()
defer ResetCategoryRegistry()

Expand All @@ -101,7 +96,6 @@ func TestCategoryRegistry_AllCategories(t *testing.T) {
}

func TestResolveCategory_Convenience(t *testing.T) {
t.Parallel()
ResetCategoryRegistry()
defer ResetCategoryRegistry()

Expand Down
2 changes: 0 additions & 2 deletions config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (
)

func TestResolveProviderRequest(t *testing.T) {
t.Parallel()
// Clear provider env vars to test default resolution
os.Unsetenv("OPENAI_BASE_URL")
os.Unsetenv("OPENAI_API_BASE")
Expand Down Expand Up @@ -56,7 +55,6 @@ func TestIsLocalProviderURL(t *testing.T) {
}

func TestIsOpenAICompatibleRuntimeEnabled(t *testing.T) {
t.Parallel()
store := &credentials.MapStore{}
credentials.SetDefaultStore(store)
t.Cleanup(func() { credentials.SetDefaultStore(nil) })
Expand Down
4 changes: 0 additions & 4 deletions config/runtime_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ func TestProviderModelEnvKeys_AllProvidersPresent(t *testing.T) {
}

func TestResolveOpenAICompatibleRuntime_WithEnv(t *testing.T) {
t.Parallel()
store := &credentials.MapStore{}
credentials.SetDefaultStore(store)
t.Cleanup(func() { credentials.SetDefaultStore(nil) })
Expand All @@ -141,7 +140,6 @@ func TestResolveOpenAICompatibleRuntime_WithEnv(t *testing.T) {
}

func TestResolveOpenAICompatibleRuntime_GrokProvider(t *testing.T) {
t.Parallel()
store := &credentials.MapStore{}
credentials.SetDefaultStore(store)
t.Cleanup(func() { credentials.SetDefaultStore(nil) })
Expand All @@ -160,7 +158,6 @@ func TestResolveOpenAICompatibleRuntime_GrokProvider(t *testing.T) {
}

func TestResolveOpenAICompatibleRuntime_FallbackModel(t *testing.T) {
t.Parallel()
clearKeys := []string{
"OPENROUTER_API_KEY", "XAI_API_KEY", "GEMINI_API_KEY",
"ANTHROPIC_API_KEY", "CANOPYWAVE_API_KEY", "DEEPSEEK_API_KEY", "ZAI_API_KEY", "OPENAI_API_KEY",
Expand All @@ -180,7 +177,6 @@ func TestResolveOpenAICompatibleRuntime_FallbackModel(t *testing.T) {
}

func TestResolveOpenAICompatibleRuntime_NoKeys(t *testing.T) {
t.Parallel()
store := &credentials.MapStore{}
credentials.SetDefaultStore(store)
t.Cleanup(func() { credentials.SetDefaultStore(nil) })
Expand Down
Loading