Feat: support broadcast API#16
Merged
InftyAI-Agent merged 5 commits intoJun 14, 2026
Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
InftyAI-Agent
added
needs-triage
InftyAI-Agent
added
the
approved
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Python-level “broadcast” API to execute a command across multiple connected daemons (filtered by labels), and refactors the Python package layout to introduce explicit sync/async client modules.
Changes:
- Added
Server.broadcast()(Python) plus new Python model wrappers (CommandResult,ServerStats). - Updated Rust
exec()timeout handling and added a daemon “busy” helper on the registry connection object. - Expanded E2E coverage with broadcast-related tests and updated concurrency expectations.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/registry.rs | Adds DaemonConnection::is_busy() and reformats list_all signature. |
| server/src/lib.rs | Adjusts exec wait timeout and minor formatting for list_daemons. |
| README.md | Removes a “Key Design” statement from the overview. |
| python/tests/test_e2e.py | Updates same-daemon concurrency test expectations and adds broadcast E2E tests. |
| python/sandd/server.py | Introduces a new sync Python wrapper Server including broadcast(). |
| python/sandd/models.py | Adds Python wrappers for Rust-returned result/stat structs. |
| python/sandd/async_server.py | Adds an AsyncServer placeholder (currently unimplemented). |
| python/sandd/init.py | Refactors package exports to the new module layout and exports AsyncServer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: kerthcet <kerthcet@gmail.com>
Member
Author
|
/lgtm |
InftyAI-Agent
added
lgtm
InftyAI-Agent
approved these changes
Jun 14, 2026
InftyAI-Agent
left a comment
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
InftyAI-Agent
approved these changes
Jun 14, 2026
InftyAI-Agent
left a comment
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?