Skip to content

COMP: Audit — disable all CTest warning suppressions to surface hidden warnings #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hjmjohnson wants to merge 1 commit into from
+61 −59
Closed

COMP: Audit — disable all CTest warning suppressions to surface hidden warnings #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 61 additions & 59 deletions CMake/CTestCustom.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,75 +34,77 @@ set(CTEST_CUSTOM_COVERAGE_EXCLUDE
".*/Utilities/.*"
)

# AUDIT: every warning suppression below is temporarily disabled so CI
# surfaces the warnings each pattern was hiding. Restore selectively.
set(CTEST_CUSTOM_WARNING_EXCEPTION
${CTEST_CUSTOM_WARNING_EXCEPTION}
"has no symbols"
"UseITK\\.cmake"
"This warning is for project developers"
"DirectWarningToFile"
"WITH_MAINTAINER_WARNINGS"
"which will suppress this warning"
"WARNING: Cache entry deserialization failed, entry ignored"
"LabelGeometryImageFilter.*deprecated"
"WARNING: Duplicate C\+\+ declaration"
"note: declared here"
"RemovedInSphinx[0-9]+Warning"
"ipo: warning #11053"
"ipo: warning #11053"
"vxl.core.vnl.algo"
"vxl.core.vnl"
"vxl.v3p.netlib"
"itkjpeg"
"usr.include.stdint.h"
"Warning itk::Statistics::Histogram"
"itkIOCommonTest.cxx:.*warning:.* is deprecated"
"/usr/bin/ld: warning: libnetcdf.so.3, needed by.*may conflict with libnetcdf.so.4"
"itkQuadEdgeMeshEdgeMergeDecimationFilter.hxx:.*warning: unused parameter.*iEdge.*"
"vnl_diag_matrix.h"
"WARNING non-zero return value in ctest"
"Warning.*Anachronism.*"
"attempted multiple inclusion of file"
"warning LNK4221"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Dd][Ii][Cc][Oo][Mm][Pp]arser[/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Ee]xpat[/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Jj][Pp][Ee][Gg][/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Kk][Ww][Ss]ys[/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Mm]eta[Ii][Oo][/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Nn]etlib[/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Nn][Ii][Ff][Tt][Ii][/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Oo]pen[Jj][Pp][Ee][Gg][/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Pp][Nn][Gg][/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Tt][Ii][Ff][Ff][/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Vv][Nn][Ll][/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Vv][Nn][Ll][Ii]nstantiation[/\\\\].*[Ww]arning.*"
".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Zz][Ll][Ii][Bb][/\\\\].*[Ww]arning.*"
".*Microsoft.*include.*win.*.h.*[Ww]arning.*"
".*include.opencv2.*warning.*"
".*core.vidl.*warning.*"
".*core.vnl.vnl_matrix_fixed.h.*warning.*"
# DCMTK
"Note: checking out.*"
"-- Warning: SNDFILE support will be disabled because libsndfile was not found.*"
# FFTW ExternalProject
".*fftw[fd]/src/fftw[fd]./*"
"libtool: install: warning: relinking .libfftw3f?_threads.la."
# OpenCV
"opencv/modules"

# Ignore clang's summary warning, assuming prior text has matched some
# other warning expression:
"[0-9,]+ warnings? generated."
# "has no symbols"
# "UseITK\\.cmake"
# "This warning is for project developers"
# "DirectWarningToFile"
# "WITH_MAINTAINER_WARNINGS"
# "which will suppress this warning"
# "WARNING: Cache entry deserialization failed, entry ignored"
# "LabelGeometryImageFilter.*deprecated"
# "WARNING: Duplicate C\+\+ declaration"
# "note: declared here"
# "RemovedInSphinx[0-9]+Warning"
# "ipo: warning #11053"
# "ipo: warning #11053"
# "vxl.core.vnl.algo"
# "vxl.core.vnl"
# "vxl.v3p.netlib"
# "itkjpeg"
# "usr.include.stdint.h"
# "Warning itk::Statistics::Histogram"
# "itkIOCommonTest.cxx:.*warning:.* is deprecated"
# "/usr/bin/ld: warning: libnetcdf.so.3, needed by.*may conflict with libnetcdf.so.4"
# "itkQuadEdgeMeshEdgeMergeDecimationFilter.hxx:.*warning: unused parameter.*iEdge.*"
# "vnl_diag_matrix.h"
# "WARNING non-zero return value in ctest"
# "Warning.*Anachronism.*"
# "attempted multiple inclusion of file"
# "warning LNK4221"
# ".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Dd][Ii][Cc][Oo][Mm][Pp]arser[/\\\\].*[Ww]arning.*"
# ".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Ee]xpat[/\\\\].*[Ww]arning.*"
# ".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Jj][Pp][Ee][Gg][/\\\\].*[Ww]arning.*"
# ".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Kk][Ww][Ss]ys[/\\\\].*[Ww]arning.*"
# ".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Mm]eta[Ii][Oo][/\\\\].*[Ww]arning.*"
# ".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Nn]etlib[/\\\\].*[Ww]arning.*"
# ".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Nn][Ii][Ff][Tt][Ii][/\\\\].*[Ww]arning.*"
# ".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Oo]pen[Jj][Pp][Ee][Gg][/\\\\].*[Ww]arning.*"
# ".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Pp][Nn][Gg][/\\\\].*[Ww]arning.*"
# ".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Tt][Ii][Ff][Ff][/\\\\].*[Ww]arning.*"
# ".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Vv][Nn][Ll][/\\\\].*[Ww]arning.*"
# ".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Vv][Nn][Ll][Ii]nstantiation[/\\\\].*[Ww]arning.*"
# ".*[/\\\\][Mm]odules[/\\\\][Tt]hird[Pp]arty[/\\\\][Zz][Ll][Ii][Bb][/\\\\].*[Ww]arning.*"
# ".*Microsoft.*include.*win.*.h.*[Ww]arning.*"
# ".*include.opencv2.*warning.*"
# ".*core.vidl.*warning.*"
# ".*core.vnl.vnl_matrix_fixed.h.*warning.*"
# # DCMTK
# "Note: checking out.*"
# "-- Warning: SNDFILE support will be disabled because libsndfile was not found.*"
# # FFTW ExternalProject
# ".*fftw[fd]/src/fftw[fd]./*"
# "libtool: install: warning: relinking .libfftw3f?_threads.la."
# # OpenCV
# "opencv/modules"
#
# # Ignore clang's summary warning, assuming prior text has matched some
# # other warning expression:
# "[0-9,]+ warnings? generated."
)

if(APPLE)
set(CTEST_CUSTOM_WARNING_EXCEPTION
${CTEST_CUSTOM_WARNING_EXCEPTION}
"warning -.: directory name .* does not exist"
"ld.*warning.*duplicate dylib.*"
# "warning -.: directory name .* does not exist"
# "ld.*warning.*duplicate dylib.*"
)
endif()

set(CTEST_CUSTOM_ERROR_EXCEPTION
${CTEST_CUSTOM_ERROR_EXCEPTION}
"RemovedInSphinx[0-9]+Warning"
# "RemovedInSphinx[0-9]+Warning"
)
Loading