Skip to content

Update example and docs#1241

Closed
thirtysixbananas wants to merge 3 commits into
JuliaWeb:masterfrom
thirtysixbananas:noexcess
Closed

Update example and docs#1241
thirtysixbananas wants to merge 3 commits into
JuliaWeb:masterfrom
thirtysixbananas:noexcess

Conversation

@thirtysixbananas

Copy link
Copy Markdown

This example failed. Looking at the code there's never any "excess", as the channel type is socketready = Channel{Tuple{IO, Response}}(0).

At first I thought this was just an outdated example, what confuses me is that from git blame I can't tell why someone thought there was an excess. Maybe it's just a mistake, as opposed to being out of date, or maybe I'm missing something.

Please review.

@thirtysixbananas

Copy link
Copy Markdown
Author

I also suggest updating the url. The previous one returned 301 permanent redirect, so a user doesn't actually see the upgrade which is the point of the example.

Before:

HTTP/1.1 301 Moved Permanently
location: https://echo.websocket.org/
server: Fly/fbde0e6c3 (2025-12-17)
via: 1.1 fly.io
fly-request-id: 01KD2Z8F0ETXCGER8D9MG5HFF4-lhr
content-length: 0
date: Mon, 22 Dec 2025 12:06:31 GMT

After:

HTTP/1.1 101 Switching Protocols
upgrade: websocket
connection: Upgrade
sec-websocket-accept: s3pPLMBiTxaQ9kYGzzhZRbK+xOo=
date: Mon, 22 Dec 2025 12:06:57 GMT
server: Fly/fbde0e6c3 (2025-12-17)
via: 1.1 fly.io
fly-request-id: 01KD2Z976G0DZSQBX9KVN606CE-lhr

@quinnj

quinnj commented Jun 15, 2026

Copy link
Copy Markdown
Member

Sorry for the slow review/response here; closing as obsolete since openraw was actually removed in the 2.0 release (we could look into adding the functionality back if people have strong opinions)

@quinnj quinnj closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants