Add an example to parse_multipart_form docs#949
Closed
cmcaine wants to merge 2 commits into
Closed
Conversation
Member
|
This LGTM; let me try to fix the CI so we can get a clean run here since these are doc tests. |
Member
|
Looks like there's some kind of syntax error in the multipart file that is causing tests to fail. |
Contributor
Author
|
I just copied and pasted the example from my REPL, but I wasn't on master, maybe the exact printed output has changed or something. I can try again on Friday |
quinnj
added a commit
that referenced
this pull request
Jun 15, 2026
The 2.0 rewrite carried parse_multipart_form forward (with a new Request overload) but its docstring had no example. Add a runnable jldoctest showing boundary-based parsing of a field + a file upload and accessing each part's name/filename/contenttype/data, plus a short server-handler snippet using the Request overload. Supersedes the stale 1.x-targeting PR #949. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Member
|
Sorry for the slow response/review here; exampled added in #1311 for the 2.X release cycle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.