WebGL1: Forbid #extension: disable after non-preprocessor tokens#3774
Merged
kenrussell merged 1 commit intoJun 24, 2026
Merged
Conversation
|
|
ladyhavoc
approved these changes
Jun 11, 2026
kenrussell
added a commit
to kenrussell/WebGL
that referenced
this pull request
Jun 24, 2026
These tests apply only to WebGL 1.0, which for historical reasons, allowed extensions to be enabled after non-preprocessor tokens. It was infeasible to allow extensions to be disabled late in shader parsing, so the spec has been revised to forbid this behavior. This does not seem to impact any WebGL applications in production. Follow-up to KhronosGroup#3774.
Member
|
Tests are up for review - merging this spec change now. |
kenrussell
added a commit
that referenced
this pull request
Jun 24, 2026
These tests apply only to WebGL 1.0, which for historical reasons, allowed extensions to be enabled after non-preprocessor tokens. It was infeasible to allow extensions to be disabled late in shader parsing, so the spec has been revised to forbid this behavior. This does not seem to impact any WebGL applications in production. Follow-up to #3774.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3772