Split the One Big Test into multiple#1527
Merged
Merged
Conversation
jessfraz
approved these changes
Mar 18, 2026
`zoo ml kcl edit gear.kcl ...` failed before reaching the API because
`Path::parent()` on a bare relative filename returns `Some("")`. We passed
that empty path to `kcl_lib::walk_dir`, which produced the empty-path
"is not a directory" error.
Treat that empty parent as the current directory, and compare canonical
paths when filtering walked files so the primary input file is not re-added
when we walk `.`.
Add a regression test covering relative file inputs from the current
directory.
This fixes the local path-handling failure. The API still expects a project
root containing `main.kcl`.
adamchalmers
force-pushed
the
achalmers/split-up-tests-properly
branch
from
52372c6 to
670b858
Compare
jtran
force-pushed
the
achalmers/split-up-tests-properly
branch
from
6180003 to
38fdbc2
Compare
* Fix test assertion to match engine output * Fix ml tests that need a main.kcl file * Fix ml reasoning to be captured, not printed directly to stderr * Fix test to not assert reason output when the server doesn't provide it
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1527 +/- ##
==========================================
+ Coverage 63.88% 64.66% +0.77%
==========================================
Files 44 44
Lines 8118 8150 +32
==========================================
+ Hits 5186 5270 +84
+ Misses 2932 2880 -52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
tests::test_mainran a lot of different tests. Now it's replaced by many small Rust tests. This way you can filter them viacargo nextestand get nice reporting, and they run in parallel so it's faster.