Fix single-dataset dive_json export emitting tracks as a list#1703
Merged
Conversation
Route the single-dataset dive_json export through crud_dataset._dive_json_export_text so tracks serialize as the canonical dict keyed by id (matching get_annotations, the multicam path, and what serializers/dive.py re-import expects). The old inline path emitted a list, which AttributeErrors on re-import. Also drops leftover debug prints.
BryonLewis
approved these changes
Jun 17, 2026
BryonLewis
left a comment
BryonLewis
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this is something I've been meaning to fix but just never got around to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single-dataset
dive_jsonexport builttracksas a list, while every other producer/consumer treats it as a dict keyed by id (get_annotations, the multicam path, theDIVEAnnotationSchematype, and the client'sMultiTrackRecord).The result: a single-cam
.dive.jsonexport can't be re-imported —serializers/dive.pycallstracks.items()and raisesAttributeError: 'list' object has no attribute 'items'.