Skip to content

refactor(sonar): use std::format#252

Merged
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar/use-std-format
Jun 9, 2026
Merged

refactor(sonar): use std::format#252
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar/use-std-format

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Use std::format and add sonar properties file.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher added this to the sonar milestone Jun 9, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
46.8% Duplication on New Code (required ≤ 2%)
1 New Code Smells (required ≤ 0)
20 Duplicated Blocks on New Code (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.87%. Comparing base (7cef15b) to head (eb6e40c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   92.87%   92.87%           
=======================================
  Files          35       35           
  Lines        2289     2289           
  Branches     1126     1126           
=======================================
  Hits         2126     2126           
  Misses         67       67           
  Partials       96       96           
Flag Coverage Δ
Linux 93.41% <ø> (ø)
Windows-AMD64 91.88% <100.00%> (ø)
Windows-ARM64 65.14% <50.00%> (+0.04%) ⬆️
macOS 74.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/windows/win_api_utils.cpp 99.59% <100.00%> (ø)
src/windows/win_display_device_topology.cpp 97.97% <100.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cef15b...eb6e40c. Read the comment docs.

@ReenigneArcher ReenigneArcher merged commit 61a0f62 into master Jun 9, 2026
21 of 22 checks passed
@ReenigneArcher ReenigneArcher deleted the refactor/sonar/use-std-format branch June 9, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant