Skip to content

refactor(sonar): fix cpp:S6032 #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 1 commit into from
Jun 9, 2026
+10 −10
Merged

refactor(sonar): fix cpp:S6032 #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions tests/unit/windows/test_win_display_device_modes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ TEST_F_S_MOCKED(SetDisplayModes, Relaxed) {
{"DeviceId4", {1000, 2160, {90, 10}}},
};

const auto pam_initial {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto &pam_initial {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto pam_submitted {applyExpectedModesOntoInput(pam_initial, new_modes, {"DeviceId1"})};

InSequence sequence;
Expand Down Expand Up @@ -346,7 +346,7 @@ TEST_F_S_MOCKED(SetDisplayModes, Strict) {
{"DeviceId4", {3840, 2160, {90, 1}}},
};

const auto pam_initial {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto &pam_initial {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto pam_submitted {applyExpectedModesOntoInput(pam_initial, new_modes, {"DeviceId4"})};

InSequence sequence;
Expand Down Expand Up @@ -529,7 +529,7 @@ TEST_F_S_MOCKED(SetDisplayModes, Relaxed, FailedToSetDisplayConfig) {
{"DeviceId4", {1000, 2160, {90, 10}}},
};

const auto pam_initial {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto &pam_initial {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto pam_submitted {applyExpectedModesOntoInput(pam_initial, new_modes, {"DeviceId1"})};

InSequence sequence;
Expand Down Expand Up @@ -567,7 +567,7 @@ TEST_F_S_MOCKED(SetDisplayModes, Relaxed, FailedToGetCurrentDisplayModes) {
{"DeviceId4", {1000, 2160, {90, 10}}},
};

const auto pam_initial {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto &pam_initial {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto pam_submitted {applyExpectedModesOntoInput(pam_initial, new_modes, {"DeviceId1"})};

InSequence sequence;
Expand Down Expand Up @@ -609,7 +609,7 @@ TEST_F_S_MOCKED(SetDisplayModes, Strict, FailedToSetDisplayConfig) {
{"DeviceId4", {3840, 2160, {90, 1}}},
};

const auto pam_initial {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto &pam_initial {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto pam_submitted {applyExpectedModesOntoInput(pam_initial, new_modes, {"DeviceId4"})};

InSequence sequence;
Expand Down Expand Up @@ -673,7 +673,7 @@ TEST_F_S_MOCKED(SetDisplayModes, Strict, FailedToGetCurrentDisplayModes) {
{"DeviceId4", {3840, 2160, {90, 1}}},
};

const auto pam_initial {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto &pam_initial {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto pam_submitted {applyExpectedModesOntoInput(pam_initial, new_modes, {"DeviceId4"})};

InSequence sequence;
Expand Down Expand Up @@ -737,7 +737,7 @@ TEST_F_S_MOCKED(SetDisplayModes, Strict, ModesDidNotChange) {
{"DeviceId4", {3840, 2160, {90, 1}}},
};

const auto pam_initial {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto &pam_initial {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto pam_submitted {applyExpectedModesOntoInput(pam_initial, new_modes, {"DeviceId4"})};

InSequence sequence;
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/windows/test_win_display_device_primary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ TEST_F_S_MOCKED(SetAsPrimary, AlreadyPrimary) {
}

TEST_F_S_MOCKED(SetAsPrimary, DuplicatePrimaryDevicesSet) {
const auto initial_pam {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto &initial_pam {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};

auto origin_point {initial_pam->m_modes.at(initial_pam->m_paths.at(1).sourceInfo.sourceModeInfoIdx).sourceMode.position};
auto expected_pam {initial_pam};
Expand Down Expand Up @@ -218,7 +218,7 @@ TEST_F_S_MOCKED(SetAsPrimary, DuplicatePrimaryDevicesSet) {
}

TEST_F_S_MOCKED(SetAsPrimary, NonDuplicatePrimaryDeviceSet) {
const auto initial_pam {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto &initial_pam {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};

auto origin_point {initial_pam->m_modes.at(initial_pam->m_paths.at(3).sourceInfo.sourceModeInfoIdx).sourceMode.position};
auto expected_pam {initial_pam};
Expand Down Expand Up @@ -345,7 +345,7 @@ TEST_F_S_MOCKED(SetAsPrimary, FailedToGetSourceMode, DuringShift) {
}

TEST_F_S_MOCKED(SetAsPrimary, FailedToSetDisplayConfig) {
const auto initial_pam {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};
const auto &initial_pam {ut_consts::PAM_4_ACTIVE_WITH_2_DUPLICATES};

auto origin_point {initial_pam->m_modes.at(initial_pam->m_paths.at(3).sourceInfo.sourceModeInfoIdx).sourceMode.position};
auto expected_pam {initial_pam};
Expand Down
Loading