[Fix] MCP: install curl for container healthcheck#1583
Conversation
|
@CREDO23 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Dockerfile for surfsense_mcp adds a curl installation step in the deps stage via apt-get, followed by cleanup of apt package lists, to support a container healthcheck probe. ChangesDockerfile Healthcheck Dependency
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The MCP image is
python:3.12-slim, which ships withoutcurl/wget, so Coolify's default container healthcheck against/healthfails withcurl: not found. Installcurl(matching the backend image) so the probe works out of the box.Tested: image builds; inside the container
curl http://localhost:8080/health→200.High-level PR Summary
This PR fixes a container healthcheck issue in the MCP service by installing
curlin the Docker image. The basepython:3.12-slimimage doesn't includecurlorwget, which causes Coolify's default healthcheck against the/healthendpoint to fail. The fix addscurlto the image usingapt-get, following best practices by cleaning up the apt cache to keep the image size minimal.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_mcp/DockerfileSummary by CodeRabbit