Skip to content

MDEV-40056 - Galera Dynamic Variables Susceptible to RCEs#5268

Open
janlindstrom wants to merge 1 commit into
MariaDB:10.6from
mariadb-corporation:10.6-MDEV-40056
Open

MDEV-40056 - Galera Dynamic Variables Susceptible to RCEs#5268
janlindstrom wants to merge 1 commit into
MariaDB:10.6from
mariadb-corporation:10.6-MDEV-40056

Conversation

@janlindstrom

Copy link
Copy Markdown
Contributor

Make check stronger and require OpenSSL version > 1.1.1 for test case.

@janlindstrom janlindstrom self-assigned this Jun 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates SSL version requirements, skips the galera_sst_cn_injection test for OpenSSL versions below 3.0.0, and refactors wsrep_shell_char in sql/wsrep_utils.cc to use a whitelist of safe characters instead of a blacklist. The review feedback highlights two important issues: first, allowing shell expansion characters like [, ], ~, and ^ in the unquoted whitelist is risky and could lead to unexpected shell behavior or command injection; second, using string comparison (ge) for version checks is fragile and will fail for future major versions (e.g., OpenSSL 10.x), so a numeric comparison on the major version is recommended.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread sql/wsrep_utils.cc Outdated
Comment thread mysql-test/suite/galera/suite.pm
Make check stronger and require OpenSSL version > 1.1.1
for test case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants