merge queue: checking main (4efb5cb) and #1704 together#1706
Closed
mergify[bot] wants to merge 7 commits into
Closed
merge queue: checking main (4efb5cb) and #1704 together#1706mergify[bot] wants to merge 7 commits into
mergify[bot] wants to merge 7 commits into
Conversation
Wraps dialoguer::FuzzySelect behind the mergify-tui boundary: shared theming policy, Esc/Ctrl-C-as-cancel contract, and no direct dialoguer dependency in command crates. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Change-Id: Idde18b02d2d99120dda58e1cf46f2c2d8cf2c844
open::Options gains an injectable Selector (None = today's leaf default) and Outcome::Cancelled for a dismissed picker. Pure label/selection helpers are unit-tested without a TTY; the explicit-commit and non-TTY paths are untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Change-Id: I7c344cbe182329006802bbbb6221898b47d779ea
With no <commit> argument on a TTY, stack open now shows a fuzzy picker over the stack (type to filter, HEAD preselected, Esc/Ctrl-C cancels with exit 0). Non-TTY and explicit-commit invocations are byte-identical to before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Change-Id: I540f15b2f6e87fdf5a9f18a90e1d769b242225ee
console re-raises SIGINT from the raw-mode key reader, so Ctrl-C killed the process at 130 with dialoguer's hidden cursor leaked. A lazily installed handler now restores the cursor and exits 130 (the fzf convention). The picker gate also requires stderr to be a TTY — that's where dialoguer draws — and the redundant max_length cap is gone along with the terminal_size dependency. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Change-Id: I6985543c4881a539da3a264bc13e547cf6d88409
Closes the window where a Ctrl-C arriving during the picker's error path could observe PICKER_ACTIVE already false and skip the cursor restore. Also retires comments still describing the pre-130 Ctrl-C contract and the stdout-only TTY gate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Change-Id: I8a8acff6d00307546da9360e75fe0b0f58ac00ad
Bounds-check the injected selector's index (typed CliError instead of an index panic) and make the leaf-default arm panic-free if the empty-stack guard ever moves. Addresses Copilot review on #1704. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Change-Id: I4413404e83ae59af9e0950a088707ad3e03cbbac
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (4efb5cb) and #1704 are queued together for merge.
This pull request has been created by Mergify to check the mergeability of #1704.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:github-review-approved[🛡 GitHub branch protection]github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Enforce conventional commit]:title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:👀 Review Requirements]:#approved-reviews-by>=2author = dependabot[bot]author = mergify-ci-botauthor = renovate[bot]📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success=ci-gateRequired conditions to stay in the queue:
base=maingithub-review-approved[🛡 GitHub branch protection]github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]label!=manual mergeEnforce conventional commit]:title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:👀 Review Requirements]:#approved-reviews-by>=2author = dependabot[bot]author = mergify-ci-botauthor = renovate[bot]📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success=ci-gate