Skip to content

evals: add 3 formulation evals for cuopt-numerical-optimization-formulation skill#1398

Open
rgsl888prabhu wants to merge 4 commits into
mainfrom
trigger-numerical-opt-formulation-eval
Open

evals: add 3 formulation evals for cuopt-numerical-optimization-formulation skill#1398
rgsl888prabhu wants to merge 4 commits into
mainfrom
trigger-numerical-opt-formulation-eval

Conversation

@rgsl888prabhu

@rgsl888prabhu rgsl888prabhu commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Adds 2 more evals to skills/cuopt-numerical-optimization-formulation/evals/evals.json (was 1, now 3), all drawn from skill-specific formulation patterns in SKILL.md.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner June 5, 2026 15:37
@rgsl888prabhu rgsl888prabhu requested a review from Iroy30 June 5, 2026 15:37
@rgsl888prabhu rgsl888prabhu self-assigned this Jun 5, 2026
@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jun 5, 2026
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d8c6b85a-0a0c-46a2-90a7-b3b6545075b2

📥 Commits

Reviewing files that changed from the base of the PR and between 545129f and ec0e30f.

📒 Files selected for processing (2)
  • skills/cuopt-numerical-optimization-formulation/SKILL.md
  • skills/cuopt-numerical-optimization-formulation/evals/evals.json
✅ Files skipped from review due to trivial changes (2)
  • skills/cuopt-numerical-optimization-formulation/evals/evals.json
  • skills/cuopt-numerical-optimization-formulation/SKILL.md

📝 Walkthrough

Walkthrough

Adjusts SKILL.md frontmatter spacing and expands evals.json: refines the production-planning evaluation and adds two new evaluation cases (cutting-stock objective and goal programming with integer decisions).

Changes

Documentation Formatting

Layer / File(s) Summary
Frontmatter spacing adjustment
skills/cuopt-numerical-optimization-formulation/SKILL.md
Line spacing between the YAML frontmatter closing delimiter and the # Numerical Optimization Formulation heading is adjusted.

Evaluation cases updates

Layer / File(s) Summary
Add/refine evaluation cases in evals.json
skills/cuopt-numerical-optimization-formulation/evals/evals.json
Refines numopt-form-eval-001 ground_truth/expected_behavior into multiline explanations (explicitly: implicit objective = maximize profit). Adds numopt-form-eval-002 (cutting-stock objective should minimize total material consumption) and numopt-form-eval-003 (goal programming: deviation variables continuous, count decisions INTEGER). All remain “concepts only” with no code/API sequences.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

non-breaking

Suggested reviewers

  • Iroy30
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'evals: add 3 formulation evals for cuopt-numerical-optimization-formulation skill' directly and clearly summarizes the main change: adding 3 evaluation cases to the skill's evals.json file.
Description check ✅ Passed The description explains that the PR adds 2 more evals to evals.json (bringing the total from 1 to 3), which is directly related to and consistent with the changeset and title.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch trigger-numerical-opt-formulation-eval

Comment @coderabbitai help to get the list of available commands and usage tips.

@rgsl888prabhu

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

1 similar comment
@rgsl888prabhu

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Adds cutting-stock objective gotcha and goal-programming integer-decision
gotcha — both drawn from skill-specific patterns in SKILL.md that agents
without the skill typically get wrong.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@rgsl888prabhu rgsl888prabhu changed the title ci: nudge numerical-optimization-formulation skill to trigger eval evals: add 3 formulation evals for cuopt-numerical-optimization-formulation skill Jun 8, 2026
@rgsl888prabhu

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

2 similar comments
@rgsl888prabhu

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@rgsl888prabhu

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@rgsl888prabhu

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@rgsl888prabhu

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@rgsl888prabhu

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

1 similar comment
@rgsl888prabhu

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@rgsl888prabhu

Copy link
Copy Markdown
Collaborator Author

/ok to test 688fffc

@github-actions

Copy link
Copy Markdown

🔔 Hi @anandhkb @rgsl888prabhu, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you!

If this is an "epic" issue, then please add the "epic" label to this issue.
If it is a PR and not ready for review, then please convert this to draft.
If you just want to switch off this notification, then use the "skip inactivity reminder" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants