Skip to content

[19.0][MIG] hr_attendance#5705

Open
hbrunn wants to merge 1 commit into
OCA:19.0from
hbrunn:19.0-hr_attendance
Open

[19.0][MIG] hr_attendance#5705
hbrunn wants to merge 1 commit into
OCA:19.0from
hbrunn:19.0-hr_attendance

Conversation

@hbrunn

@hbrunn hbrunn commented Jun 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@hbrunn hbrunn added this to the 19.0 milestone Jun 9, 2026
@hbrunn

hbrunn commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

/ocabot migration hr_attendance

Depends on :

@legalsylvain

This comment was marked as duplicate.

@hbrunn

hbrunn commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

barcodes is nothing to do and base_geolocalize has no db changes which we treat as an implicit nothing to do

@legalsylvain

Copy link
Copy Markdown
Contributor

barcodes is nothing to do and base_geolocalize has no db changes which we treat as an implicit nothing to do

script ref.

@hbrunn

hbrunn commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

thanks @legalsylvain for the link - actually I mailed you about not finding this script a while ago but never received an answer. did you change mail addresses?

barcodes has been set to nothing to do in #5547, I don't see at first glance right now why this isn't picked up by _get_module_coverage.

for base_geolocalize, I just added #5731

specifics aside, I wonder if you agree to move get_workload.py to https://github.com/OCA/OpenUpgrade/tree/documentation/docsource/maintainer_scripts and make check_dependency.py a github action? Less manual work and the check happens instantly.

@legalsylvain

Copy link
Copy Markdown
Contributor

barcodes has been set to nothing to do in #5547, I don't see at first glance right now why this isn't picked up by _get_module_coverage.

_get_module_coverage get PR lists, parsing the "main" issue comment. (#5363 (comment))

I suspect this "multi migration comment" failed. #5547 (comment)
I recalled manually, module by module.

-> now, this comment is correctly updated. #5705 (comment)

specifics aside, I wonder if you agree to move get_workload.py to https://github.com/OCA/OpenUpgrade/tree/documentation/docsource/maintainer_scripts and make check_dependency.py a github action? Less manual work and the check happens instantly.

I'd like to, but I'm not an expert of github action. We could plan to do it in the next OCA days, if you planed to come ?

@hbrunn

hbrunn commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

I do plan to come there, but that's quite little effort, not really worth wasting the OCA days on. will do one of the coming weeks and ping you on the PR

@legalsylvain

Copy link
Copy Markdown
Contributor

will do one of the coming weeks and ping you on the PR

Thanks. please ping me if you have any questions regarding current script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants