Skip to content

refactor(ambient): overhaul implementation of the AmbientProvider#99

Merged
Joltras merged 4 commits into
mainfrom
reafactor/ambientProvider
Jun 26, 2026
Merged

refactor(ambient): overhaul implementation of the AmbientProvider#99
Joltras merged 4 commits into
mainfrom
reafactor/ambientProvider

Conversation

@theEvilReaper

Copy link
Copy Markdown
Contributor

Proposed changes

The AmbientProvider which is responsible for playing different sounds during the game has some quite issues with the sound and team handling. Also the tick logic is a bit complex. The goal of this pull request is to refactor it to make it avoid the mentioned issues

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Jun 26, 2026
@theEvilReaper theEvilReaper added the area: game Everything related to the the game module label Jun 26, 2026

@Joltras Joltras left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Joltras Joltras merged commit 25ed245 into main Jun 26, 2026
5 checks passed
@Joltras Joltras deleted the reafactor/ambientProvider branch June 26, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: game Everything related to the the game module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants