fix: resolve grouped imports correctly#213
Merged
Merged
Conversation
Grouped use imports had two separate issues. First, unknown-class diagnostics skipped only single-line import declarations. When a grouped use statement was split across multiple lines, the imported names on continuation lines were treated as ordinary class references and incorrectly flagged as missing. Second, go-to-definition on a class name inside a grouped use declaration could fail because symbol extraction recorded the grouped item without its namespace prefix, so the declaration-site reference did not carry the correct fully-qualified name. Track pending multiline use declarations until their terminating semicolon, and record grouped use items with their full namespace prefix. Add regression coverage for parser/resolved-name handling, unknown-class diagnostics, and go-to-definition on both grouped import usage sites and grouped use declarations. Relates to #128
calebdw
force-pushed
the
calebdw/push-ztvqmupluwqk
branch
from
80d0342 to
efeaafb
Compare
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grouped use imports had two separate issues.
First, unknown-class diagnostics skipped only single-line import declarations. When a grouped use statement was split across multiple lines, the imported names on continuation lines were treated as ordinary class references and incorrectly flagged as missing.
Second, go-to-definition on a class name inside a grouped use declaration could fail because symbol extraction recorded the grouped item without its namespace prefix, so the declaration-site reference did not carry the correct fully-qualified name.
Track pending multiline use declarations until their terminating semicolon, and record grouped use items with their full namespace prefix. Add regression coverage for parser/resolved-name handling, unknown-class diagnostics, and go-to-definition on both grouped import usage sites and grouped use declarations.
Relates to #128