fix: infer array type for += when operands are arrays#214
Merged
Conversation
The compound assignment operator += was unconditionally routed to arithmetic type inference, producing int|float even when both operands were arrays. PHP overloads + / += for array union, and the binary + operator already handled this correctly. Split AssignmentOperator::Addition out of the arithmetic match arm in both process_compound_assignment and the compound-assignment-as-RHS path, checking is_array_like() on either operand before falling through to numeric inference. Closes #150
calebdw
force-pushed
the
calebdw/push-yvszlwntrsww
branch
from
68ec960 to
d11ff05
Compare
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compound assignment operator += was unconditionally routed to arithmetic type inference, producing int|float even when both operands were arrays. PHP overloads + / += for array union, and the binary + operator already handled this correctly.
Split AssignmentOperator::Addition out of the arithmetic match arm in both process_compound_assignment and the compound-assignment-as-RHS path, checking is_array_like() on either operand before falling through to numeric inference.
Closes #150