fix: variable assignments in if-branches no longer leak into elseif#222
Merged
Conversation
The diagnostic scope cache already correctly records a clean scope snapshot at each elseif condition boundary (forward_walk.rs:5628-5633), preventing assignments from preceding if/elseif bodies from affecting type resolution in elseif conditions and bodies. Add regression tests to prevent future regressions: - #167: $value = true in if-branch must not make elseif see bool - #168: instanceof narrowing must not leak into elseif body Fixes #167, #168.
calebdw
force-pushed
the
calebdw/push-sqrnyzopyyqo
branch
from
5804c1e to
d854e82
Compare
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diagnostic scope cache already correctly records a clean scope snapshot at each elseif condition boundary (forward_walk.rs:5628-5633), preventing assignments from preceding if/elseif bodies from affecting type resolution in elseif conditions and bodies.
Add regression tests to prevent future regressions:
type_mismatch_argumentafter assignment in previousifbranch #167: $value = true in if-branch must not make elseif see boolunknown_memberinelseifafterinstanceofbranch #168: instanceof narrowing must not leak into elseif bodyFixes #167, #168.