internal: warn against hand-editing generated tend workflows during regen#6041
Closed
prql-bot wants to merge 2 commits into
Closed
internal: warn against hand-editing generated tend workflows during regen#6041prql-bot wants to merge 2 commits into
prql-bot wants to merge 2 commits into
Conversation
…egen A manual stopgap edit to tend-review.yaml (#6038) collided with the same change in the open 0.1.7 regen PR (#6033, generic title "update tend workflows"), leaving a duplicate `with:` key that broke lint-megalinter on main and required ci-fix #6039. Add a running-tend rule to diff against the open regen PR (by file path, not title) or route changes through .config/tend.yaml. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On 2026-06-24,
mainwent red onlint-megalinter/actionlint, blockingcheck-ok-to-mergefor every open PR, becausetend-review.yamlended up with a duplicatewith:key:This was self-inflicted by two bot PRs that both added the same
allow-unsafe-pr-checkout: trueline and merged independently:chore: update tend workflows (0.1.6 → 0.1.7). Opened 07:57, merged 04:53 next day. The regen carries the canonicalallow-unsafe-pr-checkoutline as part of the generated form.#6038 merged first, then #6033 merged on top, leaving the key declared twice. A ci-fix run then had to open #6039 to remove the redundant block.
Root cause (from the session log of run 28123112371)
Before opening #6038, the bot did run a dedup search — but keyed only on the title:
The open regen PR #6033 makes the identical change but its generic title (
chore: update tend workflows) matches none of those keywords, so the search returned nothing and the bot opened a colliding manual edit. A file-based dedup would have caught it — #6033 touches.github/workflows/tend-review.yamldirectly (verified:gh pr view 6033 --json files).Fix
Adds one bullet to the
running-tendskill's CI structure section (which already documents the regen flow): before hand-editing a generatedtend-*.yamlfile, diff it against the openchore: update tend workflowsregen PR (comparing by file path, not title) or route the change through.config/tend.yamlso the regen carries it.Gate assessment
main, blockingcheck-ok-to-mergefor all PRs until the ci-fix landed. Acts on 1 occurrence.Automated finding from
tend-review-runsrun 28158204198.