fix(integrations): namespace GitHub connect DI tokens to avoid collision#2579
Merged
jonathanlab merged 2 commits intoJun 10, 2026
Merged
Conversation
The integrations and onboarding modules both defined GITHUB_CONNECT_CLIENT
and GITHUB_CONNECT_SERVICE using identical Symbol.for() keys
("posthog.core.githubConnectClient" / "...githubConnectService"). Because
Symbol.for() returns the same global symbol, the two token sets collided in
the DI container, so binding one overwrote the other.
Namespace each set under its owning module ("posthog.core.integrations.*"
and "posthog.core.onboarding.*"), add a dedicated githubConnectModule to
bind the integrations GithubConnectService, register it in desktop
contributions, and wire the integrations GithubConnectClient (UI impl) plus
its binding-map entry in the renderer.
Generated-By: PostHog Code
Task-Id: ab590a64-c7b3-45eb-b381-083a3c75b3f0
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
tatoalo
approved these changes
Jun 10, 2026
k11kirky
approved these changes
Jun 10, 2026
Contributor
|
Reviews (1): Last reviewed commit: "Merge branch 'main' into posthog-code/na..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
integrationsandonboardingmodules both definedGITHUB_CONNECT_CLIENTandGITHUB_CONNECT_SERVICEusing identicalSymbol.for()keys:"posthog.core.githubConnectClient""posthog.core.githubConnectService"Because
Symbol.for()returns the same global symbol for a given key, the two token sets collided in the DI container — binding one set silently overwrote the other.Changes
posthog.core.integrations.githubConnectClient/...githubConnectServiceposthog.core.onboarding.githubConnectClient/...githubConnectServicegithubConnect.module.tsto bind the integrationsGithubConnectService.githubConnectModuleindesktop-contributions.ts.GithubConnectClient(UiGithubConnectClient) and add itsRendererBindingsmap entry in the renderer DI wiring.Verification
pnpm typecheckpasses (run by the pre-commit hook).Created with PostHog Code