Skip to content

docs(agents): encourage parameterised tests in test guidelines#2581

Merged
jonathanlab merged 1 commit into
mainfrom
posthog-code/encourage-parameterised-tests
Jun 10, 2026
Merged

docs(agents): encourage parameterised tests in test guidelines#2581
jonathanlab merged 1 commit into
mainfrom
posthog-code/encourage-parameterised-tests

Conversation

@jonathanlab

Copy link
Copy Markdown
Contributor

Problem

Greptile flags "Prefer a parameterised test shape" on essentially every PR. The principle is sound but uncodified, so it shows up as repetitive review noise instead of being a documented convention.

Changes

Codify the parameterised-test preference in the test guidelines:

  • Added a bullet to AGENTS.md under Testing.
  • Added a Parameterised Tests section with an it.each example to docs/testing.md, including the caveat to keep distinct cases as separate tests.

How did you test this?

Docs-only change — no tests run.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code from a Slack thread

Generated-By: PostHog Code
Task-Id: c12a0681-61c4-4c5c-ab3f-8ce2ff7d41fd
@github-actions

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 78a8352.

@greptile-apps

greptile-apps Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "docs(agents): encourage parameterised te..." | Re-trigger Greptile

@jonathanlab jonathanlab marked this pull request as ready for review June 10, 2026 16:11
@jonathanlab jonathanlab enabled auto-merge (squash) June 10, 2026 16:11
@jonathanlab jonathanlab merged commit a03fc50 into main Jun 10, 2026
20 checks passed
@jonathanlab jonathanlab deleted the posthog-code/encourage-parameterised-tests branch June 10, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants